Messages in this thread |  | | Date | Fri, 22 Dec 2023 13:52:34 +0100 | | From | Simon Horman <> | | Subject | Re: [PATCH v5 1/3] phy: handle optional regulator for PHY |
| |
On Wed, Dec 20, 2023 at 09:35:35PM +0100, Jernej Skrabec wrote: > From: Corentin Labbe <clabbe.montjoie@gmail.com> > > Add handling of optional regulators for PHY. > > Regulators need to be enabled before PHY scanning, so MDIO bus > initiate this task. > > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > Signed-off-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Hi Jernej,
> diff --git a/include/linux/phy.h b/include/linux/phy.h > index 3cc52826f18e..832cb2d4f76a 100644 > --- a/include/linux/phy.h > +++ b/include/linux/phy.h > @@ -757,6 +757,9 @@ struct phy_device { > void (*phy_link_change)(struct phy_device *phydev, bool up); > void (*adjust_link)(struct net_device *dev); > > + int regulator_cnt; > + struct regulator_bulk_data *consumers;
Please add these two new fields to the kernel doc for struct phy_device which appears a above this hunk in phy.h.
> + > #if IS_ENABLED(CONFIG_MACSEC) > /* MACsec management functions */ > const struct macsec_ops *macsec_ops;
-- pw-bot: changes-requested
|  |