lkml.org 
[lkml]   [2023]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v4 1/3] RAS: Introduce AMD Address Translation Library
From

> +++ b/drivers/ras/amd/atl/access.c
> @@ -0,0 +1,106 @@

> +static int __df_indirect_read(u16 node, u8 func, u16 reg, u8 instance_id, u32 *lo)


I suggest to reconsider the usage of double underscores for identifiers.
How do you think about to avoid that this software depends on undefined behaviour?
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus

\
 
 \ /
  Last update: 2023-12-20 16:46    [W:0.081 / U:1.760 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site