lkml.org 
[lkml]   [2023]   [Dec]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1] sched/rt: Fix rt task's sched latency statistics error in sched_stat_wait trace_point
On Wed, Dec 20, 2023 at 10:33 PM Junwen Wu <wudaemon@163.com> wrote:
>
> >>I think we'd better use if (!on_rt_rq(rt_se))
> >>
> >> + update_stats_wait_end_rt(rt_rq, rt_se);
> >>
> hi, Yafang.when execute update_stats_dequeue_rt, rt_se->on_rq is still 0, util dequeue_rt_stack,
> the method is not effect.

Ah, you are right.

> I this we can use if (p && p != rq->curr) /*Mark the end of the wait period if dequeueing task*/

Agreed.

> because schedstats is not supported for rt group,we only need to update rt_se that is realy task.
> --
> Best regards
>


--
Regards
Yafang

\
 
 \ /
  Last update: 2023-12-20 16:23    [from the cache]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and my Meterkast|Read the blog