Messages in this thread | ![/](/images/icornerl.gif) | | From | Dragos Tatulea <> | Subject | Re: [PATCH vhost v4 02/15] vdpa: Add VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag | Date | Wed, 20 Dec 2023 12:57:19 +0000 |
| |
On Wed, 2023-12-20 at 12:05 +0800, Jason Wang wrote: > On Wed, Dec 20, 2023 at 11:46 AM Jason Wang <jasowang@redhat.com> wrote: > > > > On Wed, Dec 20, 2023 at 2:09 AM Dragos Tatulea <dtatulea@nvidia.com> wrote: > > > > > > The virtio spec doesn't allow changing virtqueue addresses after > > > DRIVER_OK. Some devices do support this operation when the device is > > > suspended. The VHOST_BACKEND_F_CHANGEABLE_VQ_ADDR_IN_SUSPEND flag > > > advertises this support as a backend features. > > > > There's an ongoing effort in virtio spec to introduce the suspend state. > > > > So I wonder if it's better to just allow such behaviour? > > Actually I mean, allow drivers to modify the parameters during suspend > without a new feature. > Fine by me. Less code is better than more code. The v2 of this series would be sufficient then.
Thanks
| ![\](/images/icornerr.gif) |