Messages in this thread | ![/](/images/icornerl.gif) | | Date | Wed, 20 Dec 2023 19:44:43 -0800 | Subject | Re: [PATCH v2] dmaengine: idxd: Remove usage of the deprecated ida_simple_xx() API | From | Fenghua Yu <> |
| |
On 12/19/23 11:33, Christophe JAILLET wrote: > ida_alloc() and ida_free() should be preferred to the deprecated > ida_simple_get() and ida_simple_remove(). > > This is less verbose. > > Note that the upper limit of ida_simple_get() is exclusive, but the one of > ida_alloc_range() is inclusive. Sothis change allows one more device. > > MINORMASK is ((1U << MINORBITS) - 1), so allowing MINORMASK as a maximum value > makes sense. It is also consistent with other "ida_.*MINORMASK" and > "ida_*MINOR()" usages. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
Thanks.
-Fenghua
| ![\](/images/icornerr.gif) |