Messages in this thread Patch in this message | | | Date | Mon, 18 Dec 2023 16:30:01 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] staging: rtl8712: fix open parentheses alignment |
| |
On Sat, Dec 16, 2023 at 06:10:21PM +0000, Ryan England wrote: > @@ -639,16 +640,16 @@ int r8712_xmitframe_complete(struct _adapter *padapter, > if (p2ndxmitframe) { > u16 total_length; > > - total_length = r8712_xmitframe_aggr_next( > - pxmitbuf, p2ndxmitframe); > + total_length = r8712_xmitframe_aggr_next(pxmitbuf, > + p2ndxmitframe);
You have 100 characters now, why not put this all on one line?
> do { > - p2ndxmitframe = dequeue_xframe_ex( > - pxmitpriv, phwxmits, hwentry); > + p2ndxmitframe = dequeue_xframe_ex(pxmitpriv, > + phwxmits, > + hwentry);
Same with this? And others in this patch, try to neaten stuff up when you make this type of change.
thanks,
greg k-h
| |