Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 18 Dec 2023 10:15:22 -0500 | From | Stefan Hajnoczi <> | Subject | Re: [PATCH 2/5] virtio_blk: remove the broken zone revalidation support |
| |
On Sun, Dec 17, 2023 at 05:53:56PM +0100, Christoph Hellwig wrote: > virtblk_revalidate_zones is called unconditionally from > virtblk_config_changed_work from the virtio config_changed callback. > > virtblk_revalidate_zones is a bit odd in that it re-clears the zoned > state for host aware or non-zoned devices, which isn't needed unless the > zoned mode changed - but a zone mode change to a host managed model isn't > handled at all, and virtio_blk also doesn't handle any other config > change except for a capacity change is handled (and even if it was > the upper layers above virtio_blk wouldn't handle it very well). > > But even the useful case of a size change that would add or remove > zones isn't handled properly as blk_revalidate_disk_zones expects the > device capacity to cover all zones, but the capacity is only updated > after virtblk_revalidate_zones. > > As this code appears to be entirely untested and is getting in the way > remove it for now, but it can be readded in a fixed version with > proper test coverage if needed. > > Fixes: 95bfec41bd3d ("virtio-blk: add support for zoned block devices") > Fixes: f1ba4e674feb ("virtio-blk: fix to match virtio spec") > Signed-off-by: Christoph Hellwig <hch@lst.de> > --- > drivers/block/virtio_blk.c | 26 -------------------------- > 1 file changed, 26 deletions(-)
Fair enough.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> [unhandled content-type:application/pgp-signature] | ![\](/images/icornerr.gif) |