Messages in this thread | | | From | Javier Martinez Canillas <> | Subject | Re: [PATCH v2 1/2] dt-bindings: display: Add SSD133x OLED controllers | Date | Mon, 18 Dec 2023 16:15:13 +0100 |
| |
Conor Dooley <conor@kernel.org> writes:
Hello Conor,
Thanks a lot for your feedback.
> On Mon, Dec 18, 2023 at 02:20:35PM +0100, Javier Martinez Canillas wrote:
[...]
>> + >> + - properties: >> + width: >> + default: 96 >> + height: >> + default: 64 > > diff --git a/Documentation/devicetree/bindings/display/solomon,ssd133x.yaml b/Documentation/devicetree/bindings/display/solomon,ssd133x.yaml > index 8feee9eef0fd..ffc939c782eb 100644 > --- a/Documentation/devicetree/bindings/display/solomon,ssd133x.yaml > +++ b/Documentation/devicetree/bindings/display/solomon,ssd133x.yaml > @@ -9,24 +9,24 @@ title: Solomon SSD133x OLED Display Controllers > maintainers: > - Javier Martinez Canillas <javierm@redhat.com> > > +allOf: > + - $ref: solomon,ssd-common.yaml# > + > properties: > compatible: > enum: > - solomon,ssd1331 > > + width: > + default: 96 > + > + height: > + default: 64 > + > required: > - compatible > - reg > > -allOf: > - - $ref: solomon,ssd-common.yaml# > - > - - properties: > - width: > - default: 96 > - height: > - default: 64 > - > unevaluatedProperties: false > > examples: > > The properties stuff doesn't need to be in the allOf. Although, I took
Ok.
> the opportunity to look at ssd-common.yaml. How do the height/width here > differ from the vendor prefixed versions in that file?
Oh! That is an error in the schema that I introduced when adding the binding for the SSD132x family in commit 2d23e7d6bacb ("dt-bindings: display: Add SSD132x OLED controllers"), and I just copied it to this binding as well making the same mistake...
I'll fix that with a preparatory patch to use "solomon,{width,height}" everywhere in v3 and also include your suggested changes for this patch.
-- Best regards,
Javier Martinez Canillas Core Platforms Red Hat
| |