Messages in this thread | | | Date | Mon, 18 Dec 2023 17:02:25 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 0/3] gpio: mmio: Make driver agnostic |
| |
On Mon, Dec 18, 2023 at 02:37:48PM +0100, Bartosz Golaszewski wrote: > On Mon, Dec 18, 2023 at 2:36 PM Andy Shevchenko > <andriy.shevchenko@linux.intel.com> wrote: > > On Mon, Dec 18, 2023 at 03:35:28PM +0200, Andy Shevchenko wrote: > > > On Mon, Dec 18, 2023 at 01:43:40PM +0100, Bartosz Golaszewski wrote:
...
> > > Thank you! I guess you forgot to add --sign-off to the `git merge ...` > > > > Sorry, it's --signoff. > > I never sign-off on merges though, is it mandatory? Probably not as > there are no warnings from next like for regular commits about missing > sign-offs.
No idea. I do it as it is harmless, and makes commit more robust.
For me it's fine, but I leave for me to exclaim later "Yay, had told ya!" :-)
-- With Best Regards, Andy Shevchenko
| |