Messages in this thread | | | Date | Mon, 18 Dec 2023 15:39:05 +0100 | Subject | Re: [PATCH] ARM: MAINTAINERS: drop empty entries for removed boards | From | Krzysztof Kozlowski <> |
| |
On 18/12/2023 15:21, Arnd Bergmann wrote: > On Mon, Dec 18, 2023, at 13:45, Krzysztof Kozlowski wrote: >> Drop empty and redundant maintainer entries for boards which were >> removed to fix `scripts/get_maintainer.pl --self-test=sections` errors >> like: >> >> ./MAINTAINERS:2021: warning: section without file pattern ARM/CIRRUS >> LOGIC EDB9315A MACHINE SUPPORT > > Good catch, I wonder if I missed these in last year's board removal > or if they were already broken back then. Some of these > >> @@ -2171,11 +2166,6 @@ T: git >> git://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git >> F: arch/arm/boot/dts/nxp/vf/ >> F: arch/arm/mach-imx/*vf610* >> >> -ARM/GUMSTIX MACHINE SUPPORT >> -M: Steve Sakoman <sakoman@gmail.com> >> -L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) >> -S: Maintained > > I don't know if Steve still cares, but the board is still there > in arch/arm/mach-pxa/{gumstix,am200epd.c,am300epd.c}
I did not dig that deep before, but since you insist let's take a look:
Entry was introduced in 90b8fc34968d ("[ARM] 4867/1: Adds flash, udc, mci support for gumstix F boards") and it did not cover board files.
> >> -ARM/INTEL XSC3 (MANZANO) ARM CORE >> -M: Lennert Buytenhek <kernel@wantstofly.org> >> -L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) >> -S: Maintained > > Same here, the code is still there and used by pxa3xx: > > arch/arm/mm/*xsc3l2*
Similar see: 2b7a52a459cb ("[PATCH] Update CREDITS and MAINTAINERS entries for Lennert Buytenhek")
Adding the files to these entries would be actually changing status quo.
> >> ARM/LG1K ARCHITECTURE >> M: Chanho Min <chanho.min@lge.com> >> L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) >> @@ -2840,11 +2825,6 @@ F: arch/arm/boot/dts/synaptics/ >> F: arch/arm/mach-berlin/ >> F: arch/arm64/boot/dts/synaptics/ >> >> -ARM/TECHNOLOGIC SYSTEMS TS7250 MACHINE SUPPORT >> -M: Lennert Buytenhek <kernel@wantstofly.org> >> -L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) >> -S: Maintained > > arch/arm/mach-ep93xx/ts72xx.c is about to be obsoleted by the ongoing > DT conversion. > > >> @@ -17674,14 +17649,6 @@ L: linux-gpio@vger.kernel.org >> S: Maintained >> F: drivers/gpio/gpio-pxa.c >> >> -PXA MMCI DRIVER >> -S: Orphan >> - >> -PXA RTC DRIVER >> -M: Robert Jarzmik <robert.jarzmik@free.fr> >> -L: linux-rtc@vger.kernel.org >> -S: Maintained >> - > > drivers/mmc/host/pxamci.c and drivers/rtc/rtc-pxa.c > are still in use.
MMCI does not have maintainer.
For the RTC, I guess the intention of 57f63bc8fe79 ("rtc: update maintainership of pxa rtc driver") was to maintain the driver.
The actual problem is that all of these entries (and R-321X below) come from the times people were not putting any file paths to MAINTAINERS. They stayed like this for 15-17 years, thus being effectively noop.
Let's maybe wait till any of Cc-ed people respond and confirm they want to grow the maintainer entry to cover the files? If they don't come, I propose to remove them.
> >> >> -RDC R-321X SoC >> -M: Florian Fainelli <florian@openwrt.org> >> -S: Maintained >> - > > This is still supported and it's x86 rather than arm. > > There is a good chance that we /should/ remove it for being obsolete, > but that has to be a separate series and remove the drivers and > architecture support if we decide to go that way.
Sure.
> > I'm fairly sure this platform was originally added for use with > OpenWRT but not everything was merged and OpenWRT stopped > carrying the required patches in 2016: > > https://git.openwrt.org/?p=openwrt/openwrt.git;a=commitdiff;h=fed29fa36bf9ff387ff6e96522b1b5423fed3581 >
Best regards, Krzysztof
| |