Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 18 Dec 2023 15:00:31 +0100 | Subject | Re: [PATCH 2/2] platform/x86/intel/pmc: Fix in pmc_core_ssram_get_pmc() | From | Hans de Goede <> |
| |
Hi,
On 12/16/23 02:17, rjingar wrote: > From: Rajvi Jingar <rajvi.jingar@linux.intel.com> > > Passing PMC_IDX_MAIN in pmc_core_pmc_add() adds only primary pmc to pmcdev. > Use pmc_idx instead to add all available pmcs. > > Fixes: a01486dc4bb1 ("platform/x86/intel/pmc: Cleanup SSRAM discovery") > Signed-off-by: Rajvi Jingar <rajvi.jingar@linux.intel.com>
Thank you for your patch, I've applied this patch to my review-hans branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up in my review-hans branch once I've pushed my local branch there, which might take a while.
Once I've run some tests on this branch the patches there will be added to the platform-drivers-x86/for-next branch and eventually will be included in the pdx86 pull-request to Linus for the next merge-window.
Regards,
Hans
> --- > drivers/platform/x86/intel/pmc/core_ssram.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/intel/pmc/core_ssram.c b/drivers/platform/x86/intel/pmc/core_ssram.c > index 3501c7bd6b33..55e54207987c 100644 > --- a/drivers/platform/x86/intel/pmc/core_ssram.c > +++ b/drivers/platform/x86/intel/pmc/core_ssram.c > @@ -287,7 +287,7 @@ pmc_core_ssram_get_pmc(struct pmc_dev *pmcdev, int pmc_idx, u32 offset) > if (!map) > return -ENODEV; > > - return pmc_core_pmc_add(pmcdev, pwrm_base, map, PMC_IDX_MAIN); > + return pmc_core_pmc_add(pmcdev, pwrm_base, map, pmc_idx); > } > > int pmc_core_ssram_init(struct pmc_dev *pmcdev)
| ![\](/images/icornerr.gif) |