lkml.org 
[lkml]   [2023]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 6.6 10/18] ksmbd: avoid duplicate opinfo_put() call on error of smb21_lease_break_ack()
    Date
    From: Namjae Jeon <linkinjeon@kernel.org>

    [ Upstream commit 658609d9a618d8881bf549b5893c0ba8fcff4526 ]

    opinfo_put() could be called twice on error of smb21_lease_break_ack().
    It will cause UAF issue if opinfo is referenced on other places.

    Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
    Signed-off-by: Steve French <stfrench@microsoft.com>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    fs/smb/server/smb2pdu.c | 10 +++++-----
    1 file changed, 5 insertions(+), 5 deletions(-)

    diff --git a/fs/smb/server/smb2pdu.c b/fs/smb/server/smb2pdu.c
    index 269fbfb3cd678..c0c92898c86a1 100644
    --- a/fs/smb/server/smb2pdu.c
    +++ b/fs/smb/server/smb2pdu.c
    @@ -8205,6 +8205,11 @@ static void smb21_lease_break_ack(struct ksmbd_work *work)
    le32_to_cpu(req->LeaseState));
    }

    + if (ret < 0) {
    + rsp->hdr.Status = err;
    + goto err_out;
    + }
    +
    lease_state = lease->state;
    opinfo->op_state = OPLOCK_STATE_NONE;
    wake_up_interruptible_all(&opinfo->oplock_q);
    @@ -8212,11 +8217,6 @@ static void smb21_lease_break_ack(struct ksmbd_work *work)
    wake_up_interruptible_all(&opinfo->oplock_brk);
    opinfo_put(opinfo);

    - if (ret < 0) {
    - rsp->hdr.Status = err;
    - goto err_out;
    - }
    -
    rsp->StructureSize = cpu_to_le16(36);
    rsp->Reserved = 0;
    rsp->Flags = 0;
    --
    2.43.0

    \
     
     \ /
      Last update: 2023-12-18 13:49    [W:7.935 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site