Messages in this thread | | | Date | Mon, 18 Dec 2023 12:19:08 +0100 | From | Steffen Klassert <> | Subject | Re: [PATCH] xfrm: Use spin_lock_bh() in xfrm_input() |
| |
On Mon, Dec 18, 2023 at 12:07:50PM +0100, Eric Dumazet wrote: > On Mon, Dec 18, 2023 at 9:43 AM Zhang Yiqun <zhangyiqun@phytium.com.cn> wrote: > > > > This patch is to change spin_lock() into spin_lock_bh(), which can > > disable bottem half in calling. If we leave this as spin_lock(), > > it may stuck in a deadlock, because the callback in bottem half in > > crypto driver will also call xfrm_input() again. > > > > Signed-off-by: Zhang Yiqun <zhangyiqun@phytium.com.cn> > > When was the bug added ? > We need a FIxes: tag.
This looks more like a 'crypto driver' bug. xfrm_input() runs in the RX path and therefore expects to run with BHs off.
| |