lkml.org 
[lkml]   [2023]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] HID: google_hammer: Fix invalid ENOSYS warning and unsigned.
On Tue, 12 Dec 2023, Guy Chronister wrote:

> Fixed warnings about ENOSYS and bare unsigned without int.
>
> Signed-off-by: Guy Chronister <guylovesbritt@gmail.com>
> ---
> drivers/hid/hid-google-hammer.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c
> index c6bdb9c4ef3e..d567f020bead 100644
> --- a/drivers/hid/hid-google-hammer.c
> +++ b/drivers/hid/hid-google-hammer.c
> @@ -324,7 +324,7 @@ static int hammer_kbd_brightness_set_blocking(struct led_classdev *cdev,
> }
>
> ret = hid_hw_output_report(led->hdev, led->buf, sizeof(led->buf));
> - if (ret == -ENOSYS)
> + if (ret == -EINVAL)
> ret = hid_hw_raw_request(led->hdev, 0, led->buf,
> sizeof(led->buf),
> HID_OUTPUT_REPORT,

Could you please elaborate why this is funcionally correct thing to do?
How are you now handling the special case when
hdev->ll_driver->output_report() callback doesn't exist for the specific
low-level driver?

--
Jiri Kosina
SUSE Labs


\
 
 \ /
  Last update: 2023-12-18 11:07    [W:0.065 / U:1.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site