lkml.org 
[lkml]   [2023]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] regulator: of: Remove redundant check in of_get_regulation_constraints
Date
The pointer 'suspend_state' cannot be NULL after the switch statement
so remove the redundant check.

Found by Linux Verification Center (linuxtesting.org) with the Svace static
analysis tool.

Signed-off-by: Karina Yankevich <k.yankevich@omp.ru>
---
drivers/regulator/of_regulator.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/drivers/regulator/of_regulator.c b/drivers/regulator/of_regulator.c
index 1b65e5e4e40f..c926779523ca 100644
--- a/drivers/regulator/of_regulator.c
+++ b/drivers/regulator/of_regulator.c
@@ -266,10 +266,6 @@ static int of_get_regulation_constraints(struct device *dev,
suspend_np = of_get_child_by_name(np, regulator_states[i]);
if (!suspend_np)
continue;
- if (!suspend_state) {
- of_node_put(suspend_np);
- continue;
- }

if (!of_property_read_u32(suspend_np, "regulator-mode",
&pval)) {
--
2.25.1

\
 
 \ /
  Last update: 2023-12-18 11:01    [W:0.273 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site