lkml.org 
[lkml]   [2023]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 5/6] pwm: bcm2835: Allow PWM driver to be used in atomic context
On Tue, Dec 12, 2023 at 07:14:44PM +0100, Uwe Kleine-König wrote:
> Hello Sean,
>
> On Tue, Dec 12, 2023 at 05:08:38PM +0100, Uwe Kleine-König wrote:
> > On Tue, Dec 12, 2023 at 08:34:04AM +0000, Sean Young wrote:
> > > @@ -169,6 +179,7 @@ static int bcm2835_pwm_suspend(struct device *dev)
> > > {
> > > struct bcm2835_pwm *pc = dev_get_drvdata(dev);
> > >
> > > + clk_rate_exclusive_put(pc->clk);
> > > clk_disable_unprepare(pc->clk);
> >
> > I thought this was the remove function, but that's suspend. Adding
> > clk_rate_exclusive_put() there is wrong.
>
> https://lore.kernel.org/linux-clk/744a6371f94fe96f527eea6e52a600914e6fb6b5.1702403904.git.u.kleine-koenig@pengutronix.de/
> might be useful to fix this.

That does look useful, I suppose I can only use it once it's merged in
pwm-next though. Leaving out for v9.

Thanks,
Sean

\
 
 \ /
  Last update: 2023-12-18 10:11    [W:0.079 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site