Messages in this thread | | | Date | Mon, 18 Dec 2023 13:18:17 -0800 | From | Boqun Feng <> | Subject | Re: [PATCH v2 4/4] rust: sync: update integer types in CondVar |
| |
On Sat, Dec 16, 2023 at 03:31:42PM +0000, Alice Ryhl wrote: [...] > > +const TASK_NORMAL: c_uint = bindings::TASK_NORMAL as c_uint; > +const TASK_INTERRUPTIBLE: c_int = bindings::TASK_INTERRUPTIBLE as c_int; > +const TASK_UNINTERRUPTIBLE: c_int = bindings::TASK_UNINTERRUPTIBLE as c_int; > +
Similarly, these definitions are better in rust/kernel/task.rs.
The rest looks fine to me.
Reviewed-by: Boqun Feng <boqun.feng@gmail.com>
Regards, Boqun
| |