Messages in this thread | | | Date | Mon, 18 Dec 2023 13:47:11 -0700 | Subject | Re: [PATCH v3 3/3] selftests: livepatch: Test livepatching a heavily called syscall | From | Shuah Khan <> |
| |
On 12/15/23 13:36, Joe Lawrence wrote: > On 12/11/23 16:53, Shuah Khan wrote: >> On 12/6/23 07:39, Miroslav Benes wrote: >>> Hi, >>> >>> On Tue, 5 Dec 2023, Shuah Khan wrote: >>> >>>> On 12/5/23 05:52, mpdesouza@suse.com wrote: >>>>> On Fri, 2023-12-01 at 16:38 +0000, Shuah Khan wrote: >>>> >>>>> 0003-selftests-livepatch-Test-livepatching-a-heavily-call.patch has >>>>> style problems, please review. >>>>> >>>>> NOTE: If any of the errors are false positives, please report >>>>> them to the maintainer, see CHECKPATCH in MAINTAINERS. >>>>> >>>>> I couldn't find any mention about "missing module name". Is your script >>>>> showing more warnings than these ones? Can you please share your >>>>> output? >>>>> >>>>> I'll fix MAINTAINERS file but I'll wait until I understand what's >>>>> missing in your checkpatch script to resend the patchset. >>>>> >>>> >>>> Looks like it is coming a script - still my question stands on >>>> whether or not you would need a module name for this module? >>> >>> I admit I am also clueless here. The module name is given in Makefile. In >>> this case in test_modules/Makefile. I do not know of anything else. There >>> is no MODULE_NAME macro. Could you elaborate, please? >>> >> >> I see that now. >> > > Hi Shuah, > > In the other replies to this thread, Marcos noted that he would add some > text to the commit / documentation on running and building the selftests > directly in the kernel tree (that would get my Ack) ... is there > anything else to be updated for a hopefully final v4 (for your Ack)? >
I am waiting for v4 with your comments are addressed. I can take this through kselftest tree.
thanks, -- Shuah
| |