lkml.org 
[lkml]   [2023]   [Dec]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v5 3/3] x86/kexec: use pr_err() instead of pr_debug() when an error occurs
    On Sun, 17 Dec 2023 11:35:28 +0800 Yuntao Wang <ytcoode@gmail.com> wrote:

    > When an error is detected, use pr_err() instead of pr_debug() to output
    > log message.
    >
    > In addition, remove the unnecessary return from set_page_address().
    >
    > ...
    >
    > --- a/arch/x86/kernel/kexec-bzimage64.c
    > +++ b/arch/x86/kernel/kexec-bzimage64.c
    > @@ -424,7 +424,7 @@ static void *bzImage64_load(struct kimage *image, char *kernel,
    > * command line. Make sure it does not overflow
    > */
    > if (cmdline_len + MAX_ELFCOREHDR_STR_LEN > header->cmdline_size) {
    > - pr_debug("Appending elfcorehdr=<addr> to command line exceeds maximum allowed length\n");
    > + pr_err("Appending elfcorehdr=<addr> to command line exceeds maximum allowed length\n");
    > return ERR_PTR(-EINVAL);
    > }

    https://lkml.kernel.org/r/20231213055747.61826-4-bhe@redhat.com has
    already changed this to call kexec_dprintk(). I'll skip this patch.


    \
     
     \ /
      Last update: 2023-12-18 19:25    [W:4.828 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site