Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 18 Dec 2023 21:43:33 +0530 | From | Manivannan Sadhasivam <> | Subject | Re: [PATCH 2/3] ARM: dts: qcom: sdx55: fix USB DP/DM HS PHY interrupts |
| |
On Wed, Dec 13, 2023 at 06:31:30PM +0100, Johan Hovold wrote: > The USB DP/DM HS PHY interrupts need to be provided by the PDC interrupt > controller in order to be able to wake the system up from low-power > states and to be able to detect disconnect events, which requires > triggering on falling edges. > > A recent commit updated the trigger type but failed to change the > interrupt provider as required. This leads to the current Linux driver > failing to probe instead of printing an error during suspend and USB > wakeup not working as intended. > > Fixes: d0ec3c4c11c3 ("ARM: dts: qcom: sdx55: fix USB wakeup interrupt types") > Fixes: fea4b41022f3 ("ARM: dts: qcom: sdx55: Add USB3 and PHY support") > Cc: stable@vger.kernel.org # 5.12 > Cc: Manivannan Sadhasivam <mani@kernel.org> > Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
- Mani
> --- > arch/arm/boot/dts/qcom/qcom-sdx55.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi > index 0864c99a3da1..49910279cb71 100644 > --- a/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi > +++ b/arch/arm/boot/dts/qcom/qcom-sdx55.dtsi > @@ -585,10 +585,10 @@ usb: usb@a6f8800 { > <&gcc GCC_USB30_MASTER_CLK>; > assigned-clock-rates = <19200000>, <200000000>; > > - interrupts = <GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 198 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 158 IRQ_TYPE_EDGE_BOTH>, > - <GIC_SPI 157 IRQ_TYPE_EDGE_BOTH>; > + interrupts-extended = <&intc GIC_SPI 131 IRQ_TYPE_LEVEL_HIGH>, > + <&intc GIC_SPI 198 IRQ_TYPE_LEVEL_HIGH>, > + <&pdc 11 IRQ_TYPE_EDGE_BOTH>, > + <&pdc 10 IRQ_TYPE_EDGE_BOTH>; > interrupt-names = "hs_phy_irq", "ss_phy_irq", > "dm_hs_phy_irq", "dp_hs_phy_irq"; > > -- > 2.41.0 >
-- மணிவண்ணன் சதாசிவம்
| ![\](/images/icornerr.gif) |