Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH net-next v2 17/21] net: ravb: Keep clock request operations grouped together | From | Sergey Shtylyov <> | Date | Sat, 16 Dec 2023 22:43:47 +0300 |
| |
On 12/14/23 2:45 PM, Claudiu wrote:
> From: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > > Keep clock request operations grouped togeter to have all clock-related > code in a single place. This makes the code simpler to follow. > > Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> > --- > > Changes in v2: > - none; this patch is new > > drivers/net/ethernet/renesas/ravb_main.c | 28 ++++++++++++------------ > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c > index 38999ef1ea85..a2a64c22ec41 100644 > --- a/drivers/net/ethernet/renesas/ravb_main.c > +++ b/drivers/net/ethernet/renesas/ravb_main.c > @@ -2768,6 +2768,20 @@ static int ravb_probe(struct platform_device *pdev) > if (error) > goto out_reset_assert; > > + priv->clk = devm_clk_get(&pdev->dev, NULL); > + if (IS_ERR(priv->clk)) { > + error = PTR_ERR(priv->clk); > + goto out_reset_assert; > + } > + > + if (info->gptp_ref_clk) { > + priv->gptp_clk = devm_clk_get(&pdev->dev, "gptp"); > + if (IS_ERR(priv->gptp_clk)) { > + error = PTR_ERR(priv->gptp_clk); > + goto out_reset_assert; > + } > + } > + > priv->refclk = devm_clk_get_optional(&pdev->dev, "refclk"); > if (IS_ERR(priv->refclk)) { > error = PTR_ERR(priv->refclk);
Hmm... I think we currently have all these calls in one place. Perhaps you just shouldn't have moved this code around?
MBR, Sergey
| ![\](/images/icornerr.gif) |