Messages in this thread | | | Date | Fri, 15 Dec 2023 18:08:23 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 2/2] lib/string: shrink lib/string.i via IWYU |
| |
On Thu, Dec 14, 2023 at 09:06:13PM +0000, tanzirh@google.com wrote: > This diff uses an open source tool include-what-you-use (IWYU) to modify > the include list changing indirect includes to direct includes. > IWYU is implemented using the IWYUScripts github repository which is a tool that is > currently undergoing development. These changes seek to improve build times. > > This change to lib/string.c resulted in a preprocessed size of > lib/string.i from 26371 lines to 5259 lines (-80%) for the x86 > defconfig.
> Link: https://github.com/ClangBuiltLinux/IWYUScripts > > Signed-off-by: Tanzir Hasan <tanzirh@google.com>
Tag block should not have blank line(s).
> #include <linux/types.h> > -#include <linux/string.h> > -#include <linux/ctype.h> > -#include <linux/kernel.h> > -#include <linux/export.h> > +#include <linux/bits.h> > #include <linux/bug.h> > #include <linux/errno.h> > -#include <linux/slab.h> > - > +#include <asm/rwonce.h> > +#include <linux/linkage.h> > +#include <linux/stddef.h> > +#include <vdso/limits.h> > +#include <linux/string.h> > +#include <linux/ctype.h> > #include <asm/unaligned.h> > -#include <asm/byteorder.h> > #include <asm/word-at-a-time.h> > #include <asm/page.h>
My gosh, this becomes unreadable!
Please make sure you go with groups of headers from more generic to more particular, i.e.
linux/*
asm/*
vdso/*
BUT, why the heck vdso? It should be rather uapi/ or regular linux/.
-- With Best Regards, Andy Shevchenko
| |