Messages in this thread | | | Date | Fri, 15 Dec 2023 16:40:36 +0200 | From | Ioana Ciornei <> | Subject | Re: [PATCH linux-next] mlxsw: spectrum: use netif_is_macsec() instead of open code |
| |
On Fri, Dec 15, 2023 at 09:45:31PM +0800, yang.guang5@zte.com.cn wrote: > From: Yang Guang <yang.guang5@zte.com.cn> > > Open code which is dev->priv_flags & IFF_MACSEC has already defined as > netif_is_macsec(). So use netif_is_macsec() instead of open code. > No functional changed. > > Signed-off-by: Chen Haonan <chen.haonan2@zte.com.cn> > --- > include/linux/netdevice.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 1b935ee341b4..1f2b23d854c9 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -5103,7 +5103,7 @@ void netif_inherit_tso_max(struct net_device *to, > > static inline bool netif_is_macsec(const struct net_device *dev) > { > - return dev->priv_flags & IFF_MACSEC; > + return netif_is_macsec(dev); > }
So you are replacing the actual implementation of the netif_is_macsec() function with a call to the same netif_is_macsec().
How does this work?
| |