Messages in this thread | | | Date | Fri, 15 Dec 2023 15:17:12 +0100 | From | Florian Westphal <> | Subject | Re: [RFC nf-next v1 1/2] netfilter: bpf: support prog update |
| |
D. Wythe <alibuda@linux.alibaba.com> wrote: > const struct nf_defrag_hook *defrag_hook; > + const struct bpf_prog __rcu *nf_prog;
Hmm, why do we need this pointer? Can't you just re-use bpf_nf_link->link.prog?
> + rcu_assign_pointer(nf_link->nf_prog, new_prog); > + old_prog = xchg(&link->prog, new_prog);
This looks redundant, I think you can remove the nf_prog pointer again.
Rest LGTM.
| |