Messages in this thread | | | Date | Fri, 15 Dec 2023 20:16:53 +0800 | Subject | Re: [PATCH v8 14/14] dt-bindings: net: ar803x: add qca8084 PHY properties | From | Jie Luo <> |
| |
On 12/15/2023 7:25 PM, Andrew Lunn wrote: >> The "maxItems: 1" of the property resets is defined in ethernet-phy.yaml >> that is referenced by qca,ar803x.yaml, but i have 11 reset instances >> used for qca8084 PHY > > 11!?!?? Really? Why? > > I assume the order and timer matters, otherwise why would you need > 11? So the PHY driver needs to handle this, not phylib framework. So > you will be adding vendor properties to describe all 11 of them. So > ethernet-phy.yaml does not matter. > > Andrew
Since these resets need to be configured in the special sequence, and these clocks need to be configured with different clock rate.
But the clock instance get, the property name is fixed to "clock-names" according to the function of_parse_clkspec, and the reset property name is also fixed to "reset-names" from function __of_reset_control_get.
| |