Messages in this thread | | | From | John Ogness <> | Subject | Re: [PATCH printk v3 02/14] printk: Adjust mapping for 32bit seq macros | Date | Fri, 15 Dec 2023 11:16:44 +0106 |
| |
On 2023-12-15, Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote: > On 2023-12-14 22:47:49 [+0106], John Ogness wrote: >> Note: This change only applies to 32bit architectures. On 64bit >> architectures the macros are NOPs. > > You lost my authorship.
OK. Thanks for speaking up. (And thanks for doing the heavy lifting researching the needed change.)
> But serious matter: Is this bug already present in the current printk > tree or is this code just not used and enabled later? Patch #1 from > this series moves the sequence around so is this problem introduced in > the previous patch and fixed here?
No, it is not a bug at this point. As the commit message writes:
"Until now this mapping has been correct for all call sites."
But if the mapping is not changed here, it will become a bug after applying patch 3 of this series.
John
| |