Messages in this thread | | | Date | Fri, 15 Dec 2023 09:22:30 +0100 | Subject | Re: [PATCH v8 14/14] dt-bindings: net: ar803x: add qca8084 PHY properties | From | Krzysztof Kozlowski <> |
| |
On 15/12/2023 08:40, Luo Jie wrote: > The following properties are added for qca8084 PHY. > > 1. add the compatible string "ethernet-phy-id004d.d180" since > the PHY device is not accessible during MDIO bus register. > 2. add property "qcom,phy-addr-fixup" for customizing MDIO address. > 3. add property "qcom,phy-work-mode" for specifying qca8084 PHY > work mode. > 4. add the initial clocks and resets.
All my previous comments (sent one minute before this patchset :) ) apply. Please respond to them or implement them in v5 (not earlier than after 24h).
Best regards, Krzysztof
| |