lkml.org 
[lkml]   [2023]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] pci: rcar-gen4: Replace of_device.h with explicit of.h include
Hello,

> > > The DT of_device.h and of_platform.h date back to the separate
> > > of_platform_bus_type before it was merged into the regular platform bus.
> > > As part of that merge prepping Arm DT support 13 years ago, they
> > > "temporarily" include each other. They also include platform_device.h
> > > and of.h. As a result, there's a pretty much random mix of those include
> > > files used throughout the tree. In order to detangle these headers and
> > > replace the implicit includes with struct declarations, users need to
> > > explicitly include the correct includes.
> >
> > Applied to controller/rcar, thank you!
> >
> > [1/1] PCI: rcar-gen4: Replace of_device.h with explicit of.h include
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?id=263714f5fcf8
>
> Thank you! I completely overlooked this patch. Maybe it's too late, but I also reviewed this patch, so
>
> Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>
> It's up to you whether my tag is added to the commit or not :)

No worries. Never too late for a good review. :)

As such, I added your Reviewed-by, so it should be there, per:

https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?h=controller/rcar&id=ec215237480478ca5523ea12f58803d9b7a8a0ea

Krzysztof

\
 
 \ /
  Last update: 2023-12-14 20:23    [W:0.077 / U:0.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site