lkml.org 
[lkml]   [2023]   [Dec]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 10/13] arm64: dts: exynos: gs101: define USI8 with I2C configuration
    From
    On 14/12/2023 11:52, Tudor Ambarus wrote:
    > USI8 I2C is used to communicate with an eeprom found on the battery
    > connector. Define USI8 in I2C configuration.
    >
    > USI8 CONFIG register comes with a 0x0 reset value, meaning that USI8
    > doesn't have a default protocol (I2C, SPI, UART) at reset. Thus the
    > selection of the protocol is intentionally left for the board dtsi file.
    >
    > Signed-off-by: Tudor Ambarus <tudor.ambarus@linaro.org>
    > ---
    > arch/arm64/boot/dts/exynos/google/gs101.dtsi | 26 ++++++++++++++++++++
    > 1 file changed, 26 insertions(+)
    >
    > diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
    > index ffb7b4d89a8c..4ea1b180cd0a 100644
    > --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
    > +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
    > @@ -354,6 +354,32 @@ pinctrl_peric0: pinctrl@10840000 {
    > interrupts = <GIC_SPI 625 IRQ_TYPE_LEVEL_HIGH 0>;
    > };
    >
    > + usi8: usi@109700c0 {
    > + compatible = "google,gs101-usi",
    > + "samsung,exynos850-usi";
    > + reg = <0x109700c0 0x20>;
    > + ranges;
    > + #address-cells = <1>;
    > + #size-cells = <1>;
    > + clocks = <&cmu_peric0 CLK_DOUT_PERIC0_USI8_USI>,
    > + <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI8_USI_CLK>;
    > + clock-names = "pclk", "ipclk";
    > + samsung,sysreg = <&sysreg_peric0 0x101c>;
    > + status = "disabled";
    > +
    > + hsi2c_8: i2c@10970000 {
    > + compatible = "google,gs101-hsi2c",
    > + "samsung,exynosautov9-hsi2c";
    > + reg = <0x10970000 0xc0>;
    > + interrupts = <GIC_SPI 642
    > + IRQ_TYPE_LEVEL_HIGH 0>;

    This can be in one line. Limit of 80 is not a hard-limit. It can be
    violated if it improves readability. Especially if is about 1 character
    only.



    Best regards,
    Krzysztof


    \
     
     \ /
      Last update: 2023-12-15 09:04    [W:7.844 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site