Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 15 Dec 2023 08:22:42 +0100 | Subject | Re: [PATCH net-next v5 1/2] nfc: llcp_core: Hold a ref to llcp_local->dev when holding a ref to llcp_local | From | Krzysztof Kozlowski <> |
| |
On 14/12/2023 18:23, Siddh Raman Pant wrote: > On Wed, 13 Dec 2023 13:10:16 +0530, Krzysztof Kozlowski wrote: >>> - if (sk_acceptq_is_full(parent)) { >>> - reason = LLCP_DM_REJ; >>> - release_sock(&sock->sk); >>> - sock_put(&sock->sk); >>> - goto fail; >>> - } >>> + if (sk_acceptq_is_full(parent)) >>> + goto fail_put_sock; >> >> I would argue that you reshuffle here more code than needed for the fix. >> >> This should fix only missing dev reference, not reshuffle code. It's a >> bugfix, not cleanup. > > So this should not be done? I did it because you told to extend the > cleanup label in v3 discussion.
It can be done but not in the same commit. You must not combine fixes with other changes. Also, each commit is one logical change.
Best regards, Krzysztof
| ![\](/images/icornerr.gif) |