Messages in this thread | | | Date | Fri, 15 Dec 2023 15:45:14 -0800 | Subject | Re: [PATCH v4 00/29] selftests/resctrl: CAT test improvements & generalized test framework | From | Reinette Chatre <> |
| |
On 12/15/2023 9:45 AM, Reinette Chatre wrote: > Hi Ilpo and Shuah, > > On 12/15/2023 7:04 AM, Ilpo Järvinen wrote: >> Here's v4 series to improve resctrl selftests with generalized test >> framework and rewritten CAT test. >> >> The series contains following improvements: >> >> - Excludes shareable bits from CAT test allocation to avoid interference >> - Replaces file "sink" with a volatile variable >> - Alters read pattern to defeat HW prefetcher optimizations >> - Rewrites CAT test to make the CAT test reliable and truly measure >> if CAT is working or not >> - Introduces generalized test framework making easier to add new tests >> - Lots of other cleanups & refactoring >> >> This series has been tested across a large number of systems from >> different generations. > > Ilpo, thank you very much for this great cleanup and a creating a > reliable CAT test. This work is focused on kernel health and greatly > appreciated. > > All patches in this series should have my reviewed-by tag. For > confirmation, for this whole series: > Reviewed-by: Reinette Chatre <reinette.chatre@intel.com> > > Shuah, could you please consider this series for inclusion at > your convenience?
Just in case somebody tries this series out against kernel v6.7-rc5 ...
A problematic perf patch made it into v6.7-rc5 (v6.7-rc4 and before are fine). When testing this series against kernel v6.7-rc5 the splat reported at [1] is triggered. A perf fix [2] is already queued up so all will be fine when testing this series against a kernel with [2] merged.
Reinette
[1] https://lore.kernel.org/lkml/20231214000620.3081018-1-lucas.demarchi@intel.com/ [2] https://lore.kernel.org/lkml/20231215112450.3972309-1-mark.rutland@arm.com/
| |