Messages in this thread | | | Date | Fri, 15 Dec 2023 12:59:22 -0500 | Subject | Re: [PATCH] perf top: Use evsel's cpus to replace user_requested_cpus | From | "Liang, Kan" <> |
| |
On 2023-12-15 10:36 a.m., Arnaldo Carvalho de Melo wrote: > Kan, I also noticed that the name of the event is: > > 1K cpu_atom/cycles:P/ > > ◆ > 11K cpu_core/cycles:P/ > > If I try to use that on the command line: > > root@number:~# perf top -e cpu_atom/cycles:P/ > event syntax error: 'cpu_atom/cycles:P/' > \___ Bad event or PMU > > Unable to find PMU or event on a PMU of 'cpu_atom' > > Initial error: > event syntax error: 'cpu_atom/cycles:P/' > \___ unknown term 'cycles:P' for pmu > 'cpu_atom' > > valid terms: > event,pc,edge,offcore_rsp,ldlat,inv,umask,cmask,config,config1,config2,config3,name,period,freq,branch_type,time,call-graph,stack-size,no-inherit,inherit,max-stack,nr,no-overwrite,overwrite,driver-config,percore,aux-output,aux-sample-size,metric-id,raw,legacy-cache,hardware > Run > 'perf list' for a list of valid events > > Usage: perf top [<options>] > > -e, --event <event> event selector. use 'perf list' to list > available events > root@number:~# > > It should be: > > "cpu_atom/cycles/P"
The issue also impacts the perf record and report as well.
#perf record true [ perf record: Woken up 1 times to write data ] [ perf record: Captured and wrote 0.019 MB perf.data (16 samples) ]
#perf report --header-only | grep event # event : name = cpu_atom/cycles:P/, , id = { 7360, 7361, 7362, 7363, 7364, 7365, 7366, 7367, 7368, 7369 }, type = 0 (PERF_TYPE_HARDWARE), size = 136, config = 0xa00000000, { sample_period, sample_freq } = 3000, sample_type = IP|TID|TIME|PERIOD|IDENTIFIER, read_format = ID|LOST, disabled = 1, inherit = 1, freq = 1, enable_on_exec = 1, precise_ip = 3, sample_id_all = 1 # event : name = cpu_core/cycles:P/, , id = { 7370, 7371, 7372, 7373, 7374, 7375, 7376, 7377, 7378, 7379, 7380, 7381 }, type = 0 (PERF_TYPE_HARDWARE), size = 136, config = 0x400000000, { sample_period, sample_freq } = 3000, sample_type = IP|TID|TIME|PERIOD|IDENTIFIER, read_format = ID|LOST, disabled = 1, inherit = 1, freq = 1, enable_on_exec = 1, precise_ip = 3, sample_id_all = 1
I think we should move all the modifiers after the "/". The below patch can fix it.
https://lore.kernel.org/lkml/20231215175455.1300261-1-kan.liang@linux.intel.com/
Thanks, Kan
| |