lkml.org 
[lkml]   [2023]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    SubjectRe: [PATCH] arm64: dts: allwinner: Orange Pi One Plus PHY support
    On Tue, 12 Dec 2023 12:28:30 +0000
    Anne Macedo <retpolanne@posteo.net> wrote:

    Hi Anne,

    > Adds compatible values to mdio subnodes for Ethernet PHY representing
    > Realtek 8211 PHY to Orange Pi One Plus.

    So can you state why this would be needed? This is the RTL8211 ID,
    right? Which should be autodetected via MDIO. Looking back in my inbox
    you proposed this change before, for U-Boot, specifically, but I fail to
    find a solution or explanation what really happens here. Two Renesas .dts
    files have the same compatible, and the commit message talks about the
    reset line there, is this related?

    So can you please give some more background and explanation? That would be
    part of a good commit message anyway ("why", not "what").

    Cheers,
    Andre

    > Signed-off-by: Anne Macedo <retpolanne@posteo.net>
    > ---
    > arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts | 3 ++-
    > 1 file changed, 2 insertions(+), 1 deletion(-)
    >
    > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
    > index 29a081e72..7248ab72f 100644
    > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
    > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-orangepi-one-plus.dts
    > @@ -37,7 +37,8 @@ &emac {
    >
    > &mdio {
    > ext_rgmii_phy: ethernet-phy@1 {
    > - compatible = "ethernet-phy-ieee802.3-c22";
    > + compatible = "ethernet-phy-id001c.c915",
    > + "ethernet-phy-ieee802.3-c22";
    > reg = <1>;
    > };
    > };

    \
     
     \ /
      Last update: 2023-12-12 17:23    [W:5.872 / U:0.196 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site