lkml.org 
[lkml]   [2023]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v8 5/6] pwm: bcm2835: Allow PWM driver to be used in atomic context
    From


    On 12/12/2023 8:08 AM, Uwe Kleine-König wrote:
    > Hello Sean,
    >
    > On Tue, Dec 12, 2023 at 08:34:04AM +0000, Sean Young wrote:
    >> @@ -169,6 +179,7 @@ static int bcm2835_pwm_suspend(struct device *dev)
    >> {
    >> struct bcm2835_pwm *pc = dev_get_drvdata(dev);
    >>
    >> + clk_rate_exclusive_put(pc->clk);
    >> clk_disable_unprepare(pc->clk);
    >
    > I thought this was the remove function, but that's suspend. Adding
    > clk_rate_exclusive_put() there is wrong.

    Oh yes I missed that somehow, good catch Uwe!
    --
    Florian
    [unhandled content-type:application/pkcs7-signature]
    \
     
     \ /
      Last update: 2023-12-12 17:12    [W:7.122 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site