Messages in this thread | | | Date | Tue, 12 Dec 2023 15:35:12 +0100 | From | Maxime Chevallier <> | Subject | Re: [PATCH net] net: phy: skip LED triggers on PHYs on SFP modules |
| |
Hi Daniel
On Tue, 12 Dec 2023 00:05:35 +0000 Daniel Golle <daniel@makrotopia.org> wrote:
> Calling led_trigger_register() when attaching a PHY located on an SFP > module potentially (and practically) leads into a deadlock. > Fix this by not calling led_trigger_register() for PHYs localted on SFP > modules as such modules actually never got any LEDs.
While I don't have a fix for this issue, I think your justification isn't good. This isn't about having LEDs on the module or not, but rather the PHY triggering LED events for LEDS that can be located somewhere else on the system (like the front pannel of a switch).
So I think it would be wiser to avoid the deadlock with a proper analysis of what the locking scheme does. Maybe Andrew or Russell have a better vision of what's going-on here, I tried to dive into it but it doesn't look straightfoward to me :(
Maxime
| |