Messages in this thread | | | Date | Tue, 12 Dec 2023 14:27:15 +0100 | Subject | Re: [PATCH v4 17/17] drm/mediatek: Add comments for the structures | From | AngeloGioacchino Del Regno <> |
| |
Il 12/12/23 13:19, Hsiao Chien Sung ha scritto: > Add comments for the structures to improve readability. > > Signed-off-by: Hsiao Chien Sung <shawn.sung@mediatek.com> > --- > drivers/gpu/drm/mediatek/mtk_disp_ovl.c | 21 +++++++++++++- > drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 22 ++++++++++++-- > drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h | 32 +++++++++++++++++++++ > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 15 ++++++++++ > drivers/gpu/drm/mediatek/mtk_ethdr.c | 11 +++++++ > 5 files changed, 97 insertions(+), 4 deletions(-) >
..snip..
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > index 38d08796fae4..af80c9e50d36 100644 > --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h > @@ -46,6 +46,38 @@ enum mtk_ddp_comp_type { > > struct mtk_ddp_comp; > struct cmdq_pkt; > + > +/* struct mtk_ddp_comp_funcs - function pointers of the ddp components > + * @clk_enable: enable the clocks of the component > + * @clk_disable: disable the clocks of the component > + * @config: configure the component > + * @start: start (enable) the component > + * @stop: stop (disable) the component > + * @register_vblank_cb: to register a callback function when vblank irq occurs > + * @unregister_vblank_cb: to unregister the callback function from the vblank irq > + * @enable_vblank: enable vblank irq > + * @disable_vblank: disable vblank irq > + * @supported_rotations: return rotation capability of the component > + * @layer_nr: how many layers the component supports > + * @layer_check: to check if the state of the layer is valid for the component > + * @layer_config: to configure the component according to the state of the layer > + * @gamma_set: to set gamma for the component > + * @bgclr_in_on: turn on background color > + * @bgclr_in_off: turn off background color > + * @ctm_set: set color transformation matrix > + * @dma_dev_get: return the device that uses direct memory access > + * @get_formats: get the format that is currently in use by the component > + * @get_num_formats: get number of the formats that the component supports > + * @connect: connect the sub modules of the component > + * @disconnect: disconnect the sub modules of the component > + * @add: add the device to the component (mount them in the mutex) > + * @remove: remove the device from the component (unmount them from the mutex) > + * @encoder_index: get the encoder index of the component > + * @crc: return the start of crc array > + * @crc_cnt: how many CRCs the component supports > + * @crc_entry: get the pointer to the crc entry > + * @crc_read: call this function to read crc from the hardware component > + */ > struct mtk_ddp_comp_funcs { > int (*power_on)(struct device *dev); > void (*power_off)(struct device *dev);
Please rebase over the latest upstream kernel, as it doesn't apply like this.
After which: Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
| |