lkml.org 
[lkml]   [2023]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/4] sched/fair: Be less aggressive in calling cpufreq_update_util()
On 12/12/23 12:06, Vincent Guittot wrote:

> > @@ -6772,6 +6737,8 @@ enqueue_task_fair(struct rq *rq, struct task_struct *p, int flags)
> > enqueue_throttle:
> > assert_list_leaf_cfs_rq(rq);
> >
>
> Here and in the other places below, you lose :
>
> - } else if (decayed) {
>
> The decayed condition ensures a rate limit (~1ms) in the number of
> calls to cpufreq_update_util.
>
> enqueue/dequeue/tick don't create any sudden change in the PELT
> signals that would require to update cpufreq of the change unlike
> attach/detach

Okay, thanks for the clue. Let me rethink this again.


Cheers

--
Qais Yousef

\
 
 \ /
  Last update: 2023-12-12 14:22    [W:0.133 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site