Messages in this thread | | | From | JeeHeng Sia <> | Subject | RE: [PATCH v1 05/16] dt-bindings: clock: Add StarFive JH8100 System clock and reset generator | Date | Tue, 12 Dec 2023 10:04:29 +0000 |
| |
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Tuesday, December 12, 2023 4:43 PM > To: JeeHeng Sia <jeeheng.sia@starfivetech.com>; kernel@esmil.dk; conor@kernel.org; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; paul.walmsley@sifive.com; palmer@dabbelt.com; aou@eecs.berkeley.edu; > mturquette@baylibre.com; sboyd@kernel.org; p.zabel@pengutronix.de; emil.renner.berthing@canonical.com; Hal Feng > <hal.feng@starfivetech.com>; Xingyu Wu <xingyu.wu@starfivetech.com> > Cc: linux-riscv@lists.infradead.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-clk@vger.kernel.org; Leyfoon Tan > <leyfoon.tan@starfivetech.com> > Subject: Re: [PATCH v1 05/16] dt-bindings: clock: Add StarFive JH8100 System clock and reset generator > > On 12/12/2023 03:47, JeeHeng Sia wrote: > >>> +#define SYSCRG_CLK_NNE_ICG_EN 108 > >>> + > >>> +#define SYSCRG_CLK_END 109 > >> > >> Drop from binding header. > > Do you mean don’t define the number of clk in the header? > > Yes > > > I'll have to define > > It in the driver then.. > > And this is a problem because? Nope, not a problem. > > > Best regards, > Krzysztof
| |