Messages in this thread | | | Date | Tue, 12 Dec 2023 14:35:31 +0530 | Subject | Re: [PATCH V3 2/4] clk: qcom: Add Global Clock controller (GCC) driver for X1E80100 | From | Sibi Sankar <> |
| |
On 12/11/23 22:10, Rob Herring wrote: > On Tue, Dec 5, 2023 at 12:11 AM Sibi Sankar <quic_sibis@quicinc.com> wrote: >> >> From: Rajendra Nayak <quic_rjendra@quicinc.com> >> >> Add support for the global clock controller found on X1E80100 >> based devices. >> >> Co-developed-by: Abel Vesa <abel.vesa@linaro.org> >> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> >> Signed-off-by: Rajendra Nayak <quic_rjendra@quicinc.com> >> Co-developed-by: Sibi Sankar <quic_sibis@quicinc.com> >> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> >> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> >> --- >> >> v3: >> * Rename gcc config to CLK_X1E80100_GCC [Krzysztof/Abel/Bryan] >> * Pickup Rbs. >> >> drivers/clk/qcom/Kconfig | 10 + >> drivers/clk/qcom/Makefile | 1 + >> drivers/clk/qcom/gcc-x1e80100.c | 6807 +++++++++++++++++++++++++++++++ >> 3 files changed, 6818 insertions(+) >> create mode 100644 drivers/clk/qcom/gcc-x1e80100.c >> >> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig >> index ad1acd9b7426..a9bb50da4de5 100644 >> --- a/drivers/clk/qcom/Kconfig >> +++ b/drivers/clk/qcom/Kconfig >> @@ -20,6 +20,16 @@ menuconfig COMMON_CLK_QCOM >> >> if COMMON_CLK_QCOM >> >> +config CLK_X1E80100_GCC >> + tristate "X1E80100 Global Clock Controller" >> + depends on ARM64 || COMPILE_TEST >> + select QCOM_GDSC >> + help >> + Support for the global clock controller on Qualcomm Technologies, Inc >> + X1E80100 devices. >> + Say Y if you want to use peripheral devices such as UART, SPI, I2C, >> + USB, UFS, SD/eMMC, PCIe, etc. >> + >> config QCOM_A53PLL >> tristate "MSM8916 A53 PLL" >> help >> diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile >> index 17edd73f9839..a8498ee3595e 100644 >> --- a/drivers/clk/qcom/Makefile >> +++ b/drivers/clk/qcom/Makefile >> @@ -21,6 +21,7 @@ clk-qcom-$(CONFIG_QCOM_GDSC) += gdsc.o >> obj-$(CONFIG_APQ_GCC_8084) += gcc-apq8084.o >> obj-$(CONFIG_APQ_MMCC_8084) += mmcc-apq8084.o >> obj-$(CONFIG_CLK_GFM_LPASS_SM8250) += lpass-gfm-sm8250.o >> +obj-$(CONFIG_CLK_X1E80100_GCC) += gcc-x1e80100.o >> obj-$(CONFIG_IPQ_APSS_PLL) += apss-ipq-pll.o >> obj-$(CONFIG_IPQ_APSS_6018) += apss-ipq6018.o >> obj-$(CONFIG_IPQ_GCC_4019) += gcc-ipq4019.o >> diff --git a/drivers/clk/qcom/gcc-x1e80100.c b/drivers/clk/qcom/gcc-x1e80100.c >> new file mode 100644 >> index 000000000000..74db7fef237b >> --- /dev/null >> +++ b/drivers/clk/qcom/gcc-x1e80100.c >> @@ -0,0 +1,6807 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +/* >> + * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved. >> + */ >> + >> +#include <linux/clk-provider.h> >> +#include <linux/module.h> >> +#include <linux/of_device.h> > > Probably not a header you need as reported for linux-next. You need > platform_device.h and either of.h or mod_devicetable.h.
Thanks, Stephen already sent out a fix for the same.
> > Rob > >> -- >> 2.17.1 >>
| |