lkml.org 
[lkml]   [2023]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH v2 1/1] dt-bindings: watchdog: starfive,jh7100-wdt: Add compatible for JH8100
Date
On Tue, 12 Dec 2023 16:47:59 +0000
Conor Dooley <conor@kernel.org> wrote:

> On Tue, Dec 12, 2023 at 04:46:00PM +0000, Conor Dooley wrote:
> > On Tue, Dec 12, 2023 at 11:17:31AM +0800, Ji Sheng Teoh wrote:
> > > Add "starfive,jh8100-wdt" compatible string for StarFive's JH8100
> > > watchdog.
> > > Since JH8100 watchdog only has 1 reset signal, update binding
> > > document to support one reset for "starfive,jh8100-wdt"
> > > compatible.
> > >
> > > Signed-off-by: Ley Foon Tan <leyfoon.tan@starfivetech.com>
> > > Signed-off-by: Ji Sheng Teoh <jisheng.teoh@starfivetech.com>
> > > ---
> > > .../devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > | 2 ++ 1 file changed, 2 insertions(+)
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > index 68f3f6fd08a6..02572b16ac08 100644 ---
> > > a/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > +++
> > > b/Documentation/devicetree/bindings/watchdog/starfive,jh7100-wdt.yaml
> > > @@ -27,6 +27,7 @@ properties: enum:
> > > - starfive,jh7100-wdt
> > > - starfive,jh7110-wdt
> > > + - starfive,jh8100-wdt
> > >
> > > reg:
> > > maxItems: 1
> > > @@ -45,6 +46,7 @@ properties:
> > > - const: core
> > >
> > > resets:
> > > + minItems: 1
> > > items:
> > > - description: APB reset
> > > - description: Core reset
> >
> > This relaxes the constraints for the existing devices, please add
> > per compatible constraints to avoid doing so.
>
Thanks Conor. Just to clarify, are you suggesting to add what was done
in v1?
v1:
https://lore.kernel.org/all/20231209142723.2060196-3-jisheng.teoh@starfivetech.com/

> Also, you do not appear to have implemented the request from Krzysztof
> to express compatibility with the jh7110.
>
Ok, fix that up.

\
 
 \ /
  Last update: 2023-12-13 03:59    [W:0.102 / U:0.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site