Messages in this thread | | | Date | Tue, 12 Dec 2023 13:26:37 -0800 | From | Jakub Kicinski <> | Subject | Re: [PATCH] igb: Add null pointer check to igb_set_fw_version |
| |
On Mon, 11 Dec 2023 11:13:36 +0800 Kunwu Chan wrote: > kasprintf() returns a pointer to dynamically allocated memory > which can be NULL upon failure. > > Fixes: 1978d3ead82c ("intel: fix string truncation warnings") > Cc: Kunwu Chan <kunwu.chan@hotmail.com> > Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
The allocation is rather pointless here. Can you convert this code to use snprintf() instead? -- pw-bot: cr
| |