lkml.org 
[lkml]   [2023]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next v2] net: mvpp2: add support for mii
    On Tue, Dec 12, 2023 at 03:12:00PM +0100, Stefan Eichenberger wrote:
    > Currently, mvpp2 only supports RGMII. This commit adds support for MII.
    > The description in Marvell's functional specification seems to be wrong.
    > To enable MII, we need to set GENCONF_CTRL0_PORT3_RGMII, while for RGMII
    > we need to clear it. This is also how U-Boot handles it.
    >
    > Signed-off-by: Stefan Eichenberger <eichest@gmail.com>

    LGTM.

    Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

    Thanks!

    --
    RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
    FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

    \
     
     \ /
      Last update: 2023-12-12 20:19    [W:3.598 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site