lkml.org 
[lkml]   [2023]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [net-next PATCH 1/2] dt-bindings: Document QCA808x PHYs
    From
    On 11/12/2023 13:18, Christian Marangi wrote:
    >>> + QCA808X PHYs can have up to 3 LEDs attached.
    >>> + All 3 LEDs are disabled by default.
    >>> + 2 LEDs have dedicated pins with the 3rd LED having the
    >>> + double function of Interrupt LEDs/GPIO or additional LED.
    >>> +
    >>> + By default this special PIN is set to LED function.
    >>> +
    >>> +allOf:
    >>> + - $ref: ethernet-phy.yaml#
    >>> +
    >>> +select:
    >>> + properties:
    >>> + compatible:
    >>> + contains:
    >>> + enum:
    >>> + - ethernet-phy-id004d.d101
    >>
    >> I have impression that this is continuation of some other patchset...
    >> Anyway, id004d.d101 is specific to QCA808x?
    >>
    >
    > I used enum assuming eventually more qca808x PHY will come... Yes that
    > ID is specific and it's the id of QCA8081. Better to use const?

    No, it is fine. I just wanted to be sure that this will not be matched
    by other bindings.

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2023-12-11 17:05    [W:3.652 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site