Messages in this thread | | | Date | Mon, 11 Dec 2023 15:48:46 +0800 (CST) | From | "Andy Yan" <> | Subject | Re:Re: [PATCH v2 3/5] arm64: dts: rockchip: Add support for rk3588s based board Cool Pi 4B |
| |
Hi Krzysztof:
At 2023-12-10 19:13:26, "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org> wrote: >On 10/12/2023 09:05, Andy Yan wrote: >> CoolPi 4B is a rk3588s based SBC. >> Specification: >> - Rockchip RK3588S >> - LPDDR4 2/4/8/16 GB >> - TF scard slot > >... > >> +&i2c6 { >> + pinctrl-names = "default"; >> + pinctrl-0 = <&i2c6m3_xfer>; >> + status = "okay"; >> + >> + hym8563: rtc@51 { >> + compatible = "haoyu,hym8563"; >> + reg = <0x51>; >> + #clock-cells = <0>; >> + clock-frequency = <32768>; >> + clock-output-names = "hym8563"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&hym8563_int>; >> + interrupt-parent = <&gpio0>; >> + interrupts = <RK_PB0 IRQ_TYPE_LEVEL_LOW>; >> + status = "okay"; > >My comments about redundant statues applies to all places, not only to >one specific place...
Sorry for that, I will fix in V3
> >Best regards, >Krzysztof > > >_______________________________________________ >linux-arm-kernel mailing list >linux-arm-kernel@lists.infradead.org >http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
| |