lkml.org 
[lkml]   [2023]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH AUTOSEL 5.10 03/16] ASoC: nau8822: Fix incorrect type in assignment and cast to restricted __be16
    Date
    From: David Lin <CTLIN0@nuvoton.com>

    [ Upstream commit c1501f2597dd08601acd42256a4b0a0fc36bf302 ]

    This issue is reproduced when W=1 build in compiler gcc-12.
    The following are sparse warnings:

    sound/soc/codecs/nau8822.c:199:25: sparse: sparse: incorrect type in assignment
    sound/soc/codecs/nau8822.c:199:25: sparse: expected unsigned short
    sound/soc/codecs/nau8822.c:199:25: sparse: got restricted __be16
    sound/soc/codecs/nau8822.c:235:25: sparse: sparse: cast to restricted __be16
    sound/soc/codecs/nau8822.c:235:25: sparse: sparse: cast to restricted __be16
    sound/soc/codecs/nau8822.c:235:25: sparse: sparse: cast to restricted __be16
    sound/soc/codecs/nau8822.c:235:25: sparse: sparse: cast to restricted __be16

    Reported-by: kernel test robot <lkp@intel.com>
    Closes: https://lore.kernel.org/oe-kbuild-all/202311122320.T1opZVkP-lkp@intel.com/
    Signed-off-by: David Lin <CTLIN0@nuvoton.com>
    Link: https://lore.kernel.org/r/20231117043011.1747594-1-CTLIN0@nuvoton.com
    Signed-off-by: Mark Brown <broonie@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    sound/soc/codecs/nau8822.c | 9 ++++++---
    1 file changed, 6 insertions(+), 3 deletions(-)

    diff --git a/sound/soc/codecs/nau8822.c b/sound/soc/codecs/nau8822.c
    index d831959d8ff73..4ce15cd9ed020 100644
    --- a/sound/soc/codecs/nau8822.c
    +++ b/sound/soc/codecs/nau8822.c
    @@ -184,6 +184,7 @@ static int nau8822_eq_get(struct snd_kcontrol *kcontrol,
    struct soc_bytes_ext *params = (void *)kcontrol->private_value;
    int i, reg;
    u16 reg_val, *val;
    + __be16 tmp;

    val = (u16 *)ucontrol->value.bytes.data;
    reg = NAU8822_REG_EQ1;
    @@ -192,8 +193,8 @@ static int nau8822_eq_get(struct snd_kcontrol *kcontrol,
    /* conversion of 16-bit integers between native CPU format
    * and big endian format
    */
    - reg_val = cpu_to_be16(reg_val);
    - memcpy(val + i, &reg_val, sizeof(reg_val));
    + tmp = cpu_to_be16(reg_val);
    + memcpy(val + i, &tmp, sizeof(tmp));
    }

    return 0;
    @@ -216,6 +217,7 @@ static int nau8822_eq_put(struct snd_kcontrol *kcontrol,
    void *data;
    u16 *val, value;
    int i, reg, ret;
    + __be16 *tmp;

    data = kmemdup(ucontrol->value.bytes.data,
    params->max, GFP_KERNEL | GFP_DMA);
    @@ -228,7 +230,8 @@ static int nau8822_eq_put(struct snd_kcontrol *kcontrol,
    /* conversion of 16-bit integers between native CPU format
    * and big endian format
    */
    - value = be16_to_cpu(*(val + i));
    + tmp = (__be16 *)(val + i);
    + value = be16_to_cpup(tmp);
    ret = snd_soc_component_write(component, reg + i, value);
    if (ret) {
    dev_err(component->dev,
    --
    2.42.0
    \
     
     \ /
      Last update: 2023-12-11 15:15    [W:5.742 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site