Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 11 Dec 2023 14:31:04 +0100 | Subject | Re: [PATCH] stacktrace: check whether task has a stack before saving it | From | Ronald Wahl <> |
| |
On 01.11.23 22:59, Linus Walleij wrote: > [You don't often get email from linus.walleij@linaro.org. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ] > > On Mon, Oct 30, 2023 at 6:59 PM Ronald Wahl <rwahl@gmx.de> wrote: > >> I encountered a crash on ARM32 when trying to dump the stack of some >> zombie process. This is caused by a missing check whether the task >> actually has a valid stack. This commit adds this check. >> >> Commit 214d8ca6ee85 ("stacktrace: Provide common infrastructure") >> introduced this check for platforms that define CONFIG_ARCH_STACKWALK >> but ARM32 is not one of them. >> >> Signed-off-by: Ronald Wahl <ronald.wahl@raritan.com> > > Looks correct to me: > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Unfortunately it causes a memory leak because I forgot to call put_task_stack(task) now. Should I post v2 or a separate patch?
- ron
________________________________
Ce message, ainsi que tous les fichiers joints à ce message, peuvent contenir des informations sensibles et/ ou confidentielles ne devant pas être divulguées. Si vous n'êtes pas le destinataire de ce message (ou que vous recevez ce message par erreur), nous vous remercions de le notifier immédiatement à son expéditeur, et de détruire ce message. Toute copie, divulgation, modification, utilisation ou diffusion, non autorisée, directe ou indirecte, de tout ou partie de ce message, est strictement interdite.
This e-mail, and any document attached hereby, may contain confidential and/or privileged information. If you are not the intended recipient (or have received this e-mail in error) please notify the sender immediately and destroy this e-mail. Any unauthorized, direct or indirect, copying, disclosure, distribution or other use of the material or parts thereof is strictly forbidden.
| ![\](/images/icornerr.gif) |