lkml.org 
[lkml]   [2023]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/5] dt-bindings: phy: cadence-torrent: Add second optional input reference clock
From
Hi Conor,

On 24/07/2023 20:53, Conor Dooley wrote:
> On Mon, Jul 24, 2023 at 04:59:58PM +0200, Swapnil Jakhade wrote:
>> Torrent(SD0801) PHY supports two input reference clocks. Update bindings
>> to support dual reference clock multilink configurations.
>>
>> Signed-off-by: Swapnil Jakhade <sjakhade@cadence.com>
>> ---
>> .../bindings/phy/phy-cadence-torrent.yaml | 23 +++++++++++++------
>> 1 file changed, 16 insertions(+), 7 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
>> index dfb31314face..ddb86ee0cebf 100644
>> --- a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
>> +++ b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
>> @@ -33,16 +33,25 @@ properties:
>>
>> clocks:
>> minItems: 1
>> - maxItems: 2
>> + maxItems: 3
>> description:
>> - PHY reference clock for 1 item. Must contain an entry in clock-names.
>> - Optional Parent to enable output reference clock.
>> + PHY input reference clocks (refclk & refclk1).
>
> "refclk" and "refclk1" don't seem like great names. What is each one
> used for & should refclk1 be renamed to match its use case?

All PHYs need one refclk input. "refclk"
Some PHY variants can take a second refclk input. Both are refclks so it was
chosen to add an "1" to the name to the 2nd refclk.
Please suggest if you have a better idea. Thanks!

>
>> + Optional Parent to enable output reference clock (phy_en_refclk).
>>
>> clock-names:
>> - minItems: 1
>> - items:
>> - - const: refclk
>> - - const: phy_en_refclk
>> + oneOf:
>> + - items:
>> + - const: refclk
>> + - items:
>> + - const: refclk
>> + - const: phy_en_refclk
>> + - items:
>> + - const: refclk
>> + - const: refclk1
>> + - items:
>> + - const: refclk
>> + - const: refclk1
>> + - const: phy_en_refclk
>>
>> reg:
>> minItems: 1
>> --
>> 2.34.1
>>

--
cheers,
-roger

\
 
 \ /
  Last update: 2023-12-11 13:46    [W:0.895 / U:0.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site