Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Yury Norov <> | Subject | [PATCH v3 23/35] usb: cdc-acm: optimize acm_softint() | Date | Mon, 11 Dec 2023 18:27:37 -0800 |
| |
acm_softint() uses for-loop to traverse urbs_in_error_delay bitmap bit by bit to find and clear set bits.
Simplify it by using for_each_test_and_clear_bit(), because it doesn't test already clear bits.
Signed-off-by: Yury Norov <yury.norov@gmail.com> Acked-by: Oliver Neukum <oneukum@suse.com> --- drivers/usb/class/cdc-acm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/class/cdc-acm.c b/drivers/usb/class/cdc-acm.c index a1f4e1ead97f..8664b63050b0 100644 --- a/drivers/usb/class/cdc-acm.c +++ b/drivers/usb/class/cdc-acm.c @@ -613,9 +613,8 @@ static void acm_softint(struct work_struct *work) } if (test_and_clear_bit(ACM_ERROR_DELAY, &acm->flags)) { - for (i = 0; i < acm->rx_buflimit; i++) - if (test_and_clear_bit(i, &acm->urbs_in_error_delay)) - acm_submit_read_urb(acm, i, GFP_KERNEL); + for_each_test_and_clear_bit(i, &acm->urbs_in_error_delay, acm->rx_buflimit) + acm_submit_read_urb(acm, i, GFP_KERNEL); } if (test_and_clear_bit(EVENT_TTY_WAKEUP, &acm->flags)) -- 2.40.1
| ![\](/images/icornerr.gif) |