lkml.org 
[lkml]   [2023]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] arch/riscv/kernel/sys_riscv.c: removed asm-generic
On Mon, Dec 11, 2023 at 2:52 PM <tanzirh@google.com> wrote:
>
> arch/riscv/kernel/sys_riscv.c builds without using anything
> from asm-generic/mman-common.h. There seems to be no reason
> to include this file.
>
> Signed-off-by: Tanzir Hasan <tanzirh@google.com>
> ---
>
> ---
> arch/riscv/kernel/sys_riscv.c | 1 -

If you run `git log arch/riscv/kernel/sys_riscv.c`, you'll find the
prefix used on the oneline of the commit for this file is generally
one of:

- RISC-V:
- riscv:

You should choose one of the above rather than
`arch/riscv/kernel/sys_riscv.c:`. Sorry I missed that in internal
code review, but would you mind please sending a v2 with that fixed?
I'd expect something like:

riscv: remove unused header

+Conor who pointed this out to me on IRC

> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/sys_riscv.c b/arch/riscv/kernel/sys_riscv.c
> index a2ca5b7756a5..ebcaf386ea62 100644
> --- a/arch/riscv/kernel/sys_riscv.c
> +++ b/arch/riscv/kernel/sys_riscv.c
> @@ -14,7 +14,6 @@
> #include <asm/switch_to.h>
> #include <asm/uaccess.h>
> #include <asm/unistd.h>
> -#include <asm-generic/mman-common.h>
> #include <vdso/vsyscall.h>
>
> static long riscv_sys_mmap(unsigned long addr, unsigned long len,
>
> ---
> base-commit: a39b6ac3781d46ba18193c9dbb2110f31e9bffe9
> change-id: 20231211-removeasmgeneric-f6be13a42b6b
>
> Best regards,
> --
> Tanzir Hasan <tanzirh@google.com>
>


--
Thanks,
~Nick Desaulniers

\
 
 \ /
  Last update: 2023-12-12 01:06    [W:0.041 / U:0.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site