lkml.org 
[lkml]   [2023]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] scsi: fcoe: replace deprecated strncpy with strscpy
From
On 12/11/23 12:08, Justin Stitt wrote:
> Hi,
>
> On Tue, Oct 24, 2023 at 1:01 PM Bart Van Assche <bvanassche@acm.org> wrote:
>>
>> On 10/24/23 12:52, Justin Stitt wrote:
>>> diff --git a/drivers/scsi/fcoe/fcoe_sysfs.c b/drivers/scsi/fcoe/fcoe_sysfs.c
>>> index e17957f8085c..7a3ca6cd3030 100644
>>> --- a/drivers/scsi/fcoe/fcoe_sysfs.c
>>> +++ b/drivers/scsi/fcoe/fcoe_sysfs.c
>>> @@ -279,12 +279,10 @@ static ssize_t store_ctlr_mode(struct device *dev,
>>> if (count > FCOE_MAX_MODENAME_LEN)
>>> return -EINVAL;
>>>
>>> - strncpy(mode, buf, count);
>>> + strscpy(mode, buf, count);
>>>
>>> if (mode[count - 1] == '\n')
>>> mode[count - 1] = '\0';
>>> - else
>>> - mode[count] = '\0';
>>>
>>> switch (ctlr->enabled) {
>>> case FCOE_CTLR_ENABLED:
>>
>> Please consider to remove the code for copying the sysfs string and to
>> use sysfs_match_string() instead.
>>
>
> Sorry, I'm not too familiar with sysfs strings here.
>
> Let me know what you think of this patch [1].

I don't use FCoE so I will leave it to an FCoE user to review that patch.

Thanks,

Bart.

\
 
 \ /
  Last update: 2023-12-11 21:37    [W:0.169 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site